-
Notifications
You must be signed in to change notification settings - Fork 94
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support TSQL syntax for geospatial functions #2024
Closed
Anikait143
wants to merge
35
commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:Jira-babel-4370
Closed
Support TSQL syntax for geospatial functions #2024
Anikait143
wants to merge
35
commits into
babelfish-for-postgresql:BABEL_3_X_DEV
from
amazon-aurora:Jira-babel-4370
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
timchang514
reviewed
Nov 22, 2023
kuntalghosh
reviewed
Nov 23, 2023
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
kuntalghosh
requested changes
Nov 24, 2023
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Signed-off-by: Anikait Agrawal <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This commit contains Support for TSQL syntax for geospatial functions.
Added Handling for STX, STY, LAT, LONG, STDistance, STAsText, and STAsBinary functions.
Modified Test Cases to check TSQL syntax for geospatial functions
Supported Syntax -
select <col_name>.STX from table;
(Simple Select from table with function name at the last Similarly -select <col_name>.STAsText() from table;
)select <table_name>.<col_name>.STX from table;
(Simple Select from table with 2-parts call with function name at the last)Simple Select using a declared variable with function name at the last
Task: BABEL- 4370
Authored-by: Anikait Agrawal [email protected]
Signed-off-by: Anikait Agrawal [email protected]
Test Scenarios Covered
Use case based - JDBC -> TestSpatialPoint-vu-verify, Dotnet -> TestPoint.txt
Boundary conditions -
Arbitrary inputs -
Negative test cases -
Minor version upgrade tests -
Major version upgrade tests -
Performance tests -
Tooling impact -
Client tests -
Check List
By submitting this pull request, I confirm that my contribution is under the terms of the Apache 2.0 and PostgreSQL licenses, and grant any person obtaining a copy of the contribution permission to relicense all or a portion of my contribution to the PostgreSQL License solely to contribute all or a portion of my contribution to the PostgreSQL open source project.
For more information on following Developer Certificate of Origin and signing off your commits, please check here.